Multiple dirs class set #400
Conversation
|
How about refactoring The constructor is |
|
Yes! That was my first approach, but I found some reason to do it differently... Dont remember what it was though. :( We can even change the named constructor without a BC break. my only concern here is with the Anyway, as I can't see anymore what drove me to this approach, I will simplify as you suggest. |
hgraca
force-pushed
the
feat/multiple_dirs_class_set
branch
from
a9b0366
to
501feda
Compare
|
@jdreesen done, and force pushed |
hgraca
force-pushed
the
feat/multiple_dirs_class_set
branch
from
501feda
to
e1a979b
Compare
hgraca
force-pushed
the
feat/multiple_dirs_class_set
branch
from
e1a979b
to
f27b65a
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #400 +/- ##
=========================================
Coverage 94.33% 94.33%
Complexity 571 571
=========================================
Files 67 67
Lines 1500 1500
=========================================
Hits 1415 1415
Misses 85 85
|
|
@hgraca Before approving, can you please add something to the readme file :) ? |
hgraca
force-pushed
the
feat/multiple_dirs_class_set
branch
from
f27b65a
to
990416a
Compare
This way we can specify just the directories we want it to scan, as opposed to include all dirs in the root and then excluding all dirs we don't want in the set.
hgraca
force-pushed
the
feat/multiple_dirs_class_set
branch
from
990416a
to
7aa145e
Compare
Currently, if we want to include two folders from the project root, we need to add the root of the project and then exclude everything we dont want to include, and remember to add a folder to the config if we add a new folder to the project root.
With the
MultipleDirClassSetwe can specify just the directories we want it to scan,removing all cruft from our config.